Feature #5058
display avatars from Gravatar
| Status: | Fixed | Start date: | 04/13/2012 | |
|---|---|---|---|---|
| Priority: | High | Due date: | ||
| Assignee: |  Christian Dywan |
% Done: | 0% |
|
| Category: | - | |||
| Target version: | 0.1 | |||
| Keywords: |
Description
This would be useful as a fallback when we can't get an avatar from libfolks (#5057). (Eventually libfolks will have a Gravatar backend, but it doesn't yet.)
Related issues
Associated revisions
Closes #5058 Gravatar support
History
Updated by Christian Dywan about 1 year ago
libfolks upstream bug: https://bugzilla.gnome.org/show_bug.cgi?id=655116
The code will boil down to
+ string sender_checksum = GLib.Checksum.compute_for_string (
+ GLib.ChecksumType.MD5, Contact.address_from_string (sender));
+ return "http://www.gravatar.com/avatar/%s?d=identicon".printf (sender_checksum);
Updated by Christian Dywan about 1 year ago
- File 0001-Render-avatars-next-to-messages-with-Gravatar.-Closes.diff added
- Status changed from Open to Review
This adds CSS and an img element with class "avatar", and allows gravatar URLs to be loaded. The first email is used to get the URL.
See here for reference, and several options for fallbacks. Personally I've tried identicons and found they didn't feel right, so I'd rather go for 404 or mm. http://en.gravatar.com/site/implement/images/
Updated by Eric Gregory about 1 year ago
- Category set to 13
- Status changed from Review to 5
- Resolution set to fixed
Looks great! Glad to see this wasn't as complicated as it sounds.
This one took a while to test, no thanks to a certain Yorba employee's clever Gravatar tricking me into thinking there was a bug:
http://www.gravatar.com/avatar/e60eac4cc6fc4c766518bb8b757e401d?d=mm
Updated by Adam Dingle about 1 year ago
- Status changed from 5 to Open
- Resolution deleted (
fixed)
Let's discuss this a bit more. I personally am not wild about displaying a generic missing-avatar icon when no avatar is available, as will often be the case - I think it doesn't convey any useful information and clutters the display. If we skip it, though, then we'll probably have to shift the favorites star and menu handle to the right border, at least when there is no avatar. What if we were to display the avatar to the left of the star and menu handle, and simply use blank space in its place when no avatar is available?
Updated by Eric Gregory about 1 year ago
It's standard in modern web UIs to show a placeholder image if there's no user photo. It's what users of Google, YouTube, Facebook, Twitter, Disqus, Wordpress, etc. will expect.
That said, it looks like it's very easy to change the placeholder or eliminate it. All you have to do is change the request URL, as explained here:
https://en.gravatar.com/site/implement/images/
Updated by Adam Dingle about 1 year ago
- Status changed from Open to 5
- Resolution set to fixed
At Yorba we discussed whether to show placeholder images. We're still not sure whether we want to make a change, but if so it can be a separate bug ticket; we can consider this feature complete. Reclosing.
Updated by Charles Lindsay about 1 month ago
- Status changed from 5 to Fixed